✨ Added support for optional input parameter points in flood fill #518

Drewniok · 2024-08-30T15:22:01Z

Description

This PR adds the following:

Optional parameters can be used as input for flood fill. If they are operational, the operational domain around them is determined.
Added operational_to_total_ratio to operational_stats to track the proportion of parameter points that fall within the operational domain, relative to the total number of possible parameter points. This can be used as a value to assess how large the operational domain is compared to the total domain.

Checklist:

The pull request only contains commits that are related to it.
I have added appropriate tests and documentation.
I have added a changelog entry.
I have created/adjusted the Python bindings for any new or updated functionality.
I have made sure that all CI jobs on GitHub pass.
The pull request introduces no new warnings and follows the project's style guidelines.

…_total_ratio.

Signed-off-by: GitHub Actions <actions@github.com>

github-actions

clang-tidy made some suggestions

include/fiction/algorithms/simulation/sidb/operational_domain.hpp

test/algorithms/simulation/sidb/operational_domain.cpp

…into add_operational_to_total_ratio

bindings/pyfiction/test/algorithms/simulation/sidb/test_operational_domain.py

github-actions

clang-tidy made some suggestions

include/fiction/algorithms/simulation/sidb/operational_domain.hpp

test/algorithms/simulation/sidb/operational_domain.cpp

…into add_operational_to_total_ratio

Signed-off-by: GitHub Actions <actions@github.com>

github-actions

clang-tidy made some suggestions

include/fiction/algorithms/simulation/sidb/operational_domain.hpp

test/algorithms/simulation/sidb/operational_domain.cpp

github-actions

clang-tidy made some suggestions

include/fiction/algorithms/simulation/sidb/operational_domain.hpp

test/algorithms/simulation/sidb/operational_domain.cpp

codecov · 2024-09-02T17:25:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.16%. Comparing base (a2971b4) to head (ae4e6c7).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files         224      226    +2     
  Lines       31642    31723   +81     
  Branches     1573     1574    +1     
=======================================
+ Hits        31061    31142   +81     
  Misses        581      581

Files with missing lines	Coverage Δ
...thms/simulation/sidb/compute_operational_ratio.hpp	`100.00% <100.00%> (ø)`
.../algorithms/simulation/sidb/operational_domain.hpp	`94.37% <100.00%> (+0.08%)`	⬆️
include/fiction/io/print_layout.hpp	`95.02% <100.00%> (ø)`
include/fiction/utils/layout_utils.hpp	`98.34% <100.00%> (+0.02%)`	⬆️
...thms/simulation/sidb/compute_operational_ratio.cpp	`100.00% <100.00%> (ø)`
.../algorithms/simulation/sidb/operational_domain.cpp	`99.11% <100.00%> (+<0.01%)`	⬆️
test/io/print_layout.cpp	`100.00% <ø> (ø)`
test/utils/blueprints/layout_blueprints.hpp	`100.00% <ø> (ø)`

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2971b4...ae4e6c7. Read the comment docs.

…into add_operational_to_total_ratio

Signed-off-by: GitHub Actions <actions@github.com>

github-actions

clang-tidy made some suggestions

...yfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio_at_point.hpp

experiments/operational_domain/operational_domain_3d_bestagon.cpp

experiments/operational_domain/operational_domain_3d_siqad.cpp

experiments/operational_domain/operational_domain_bestagon.cpp

experiments/operational_domain/operational_domain_siqad.cpp

test/algorithms/simulation/sidb/compute_operational_ratio_at_point.cpp

test/algorithms/simulation/sidb/operational_domain.cpp

…into add_operational_to_total_ratio

github-actions

clang-tidy made some suggestions

...yfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio_at_point.hpp

test/algorithms/simulation/sidb/compute_operational_ratio_at_point.cpp

test/algorithms/simulation/sidb/operational_domain.cpp

github-actions

clang-tidy made some suggestions

...yfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio_at_point.hpp

test/algorithms/simulation/sidb/compute_operational_ratio_at_point.cpp

test/algorithms/simulation/sidb/operational_domain.cpp

include/fiction/algorithms/simulation/sidb/compute_operational_ratio_at_point.hpp

include/fiction/algorithms/simulation/sidb/operational_domain.hpp

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/operational_domain.hpp

...yfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio_at_point.hpp

Signed-off-by: GitHub Actions <actions@github.com>

github-actions

clang-tidy made some suggestions

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio.hpp

test/algorithms/simulation/sidb/compute_operational_ratio_at_point.cpp

test/algorithms/simulation/sidb/operational_domain.cpp

…into add_operational_to_total_ratio

github-actions

clang-tidy made some suggestions

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio.hpp

test/algorithms/simulation/sidb/compute_operational_ratio.cpp

test/algorithms/simulation/sidb/operational_domain.cpp

github-actions

clang-tidy made some suggestions

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio.hpp

test/algorithms/simulation/sidb/compute_operational_ratio.cpp

test/algorithms/simulation/sidb/operational_domain.cpp

docs/algorithms/sidb_simulation.rst

github-actions

clang-tidy made some suggestions

bindings/pyfiction/include/pyfiction/algorithms/simulation/sidb/compute_operational_ratio.hpp

test/algorithms/simulation/sidb/compute_operational_ratio.cpp

test/algorithms/simulation/sidb/operational_domain.cpp

Drewniok and others added 4 commits August 30, 2024 17:01

✨ adding additional input for parameter points and add operational_to…

5719d96

…_total_ratio.

🎨 change illustration of positively charged SiDB.

400d473

📝 Update pyfiction docstrings

ec6b3c5

Signed-off-by: GitHub Actions <actions@github.com>

📝 add docu.

365263f

Drewniok added the enhancement New feature or request label Aug 30, 2024

Drewniok self-assigned this Aug 30, 2024

Drewniok changed the title ~~✨ Add Support for Optional Parameter Points in Flood Fill~~ ✨ Added support for optional input parameter points in flood fill Aug 30, 2024

🎨 update experiments after change.

d351c46

github-actions bot reviewed Aug 30, 2024

View reviewed changes

pre-commit-ci bot and others added 3 commits August 30, 2024 15:34

🎨 Incorporated pre-commit fixes

f613dac

🎨 clang-tidy fixes.

3d6d2aa

Merge remote-tracking branch 'origin/add_operational_to_total_ratio' …

f20a3f3

…into add_operational_to_total_ratio

github-advanced-security bot found potential problems Aug 30, 2024

View reviewed changes

github-actions bot reviewed Aug 30, 2024

View reviewed changes

include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved

test/algorithms/simulation/sidb/operational_domain.cpp Outdated Show resolved Hide resolved

Drewniok and others added 3 commits August 30, 2024 19:02

🎨 small fix.

74b5f02

🎨 small fix.

b9311b4

🎨 Incorporated pre-commit fixes

9cd3af9

Drewniok requested a review from marcelwa August 30, 2024 17:07

Drewniok and others added 4 commits August 30, 2024 19:08

🎨 small fix.

3567c5d

🎨 small fix.

8885dd4

Merge remote-tracking branch 'origin/add_operational_to_total_ratio' …

cff8f8c

…into add_operational_to_total_ratio

📝 Update pyfiction docstrings

eebff77

Signed-off-by: GitHub Actions <actions@github.com>

github-actions bot reviewed Aug 30, 2024

View reviewed changes

include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved

test/algorithms/simulation/sidb/operational_domain.cpp Outdated Show resolved Hide resolved

Drewniok and others added 2 commits September 2, 2024 18:25

🎨 use circles for positive sidbs.

ca4c746

Merge branch 'main' into add_operational_to_total_ratio

f3b2966

github-actions bot reviewed Sep 2, 2024

View reviewed changes

include/fiction/algorithms/simulation/sidb/operational_domain.hpp Outdated Show resolved Hide resolved

test/algorithms/simulation/sidb/operational_domain.cpp Outdated Show resolved Hide resolved

Drewniok added 3 commits September 9, 2024 14:29

✨ new function to compute operational domain ratio.

c1b8577

Merge branch 'main' into add_operational_to_total_ratio

9fb6e07

🎨 restructuring

2c483ce

Drewniok and others added 3 commits September 16, 2024 08:05

Merge remote-tracking branch 'origin/add_operational_to_total_ratio' …

93c9a6a

…into add_operational_to_total_ratio

🐛 fix python unittest.

80cf1cf

📝 Update pyfiction docstrings

f680e9b

Signed-off-by: GitHub Actions <actions@github.com>

github-actions bot reviewed Sep 16, 2024

View reviewed changes

Drewniok added 2 commits September 16, 2024 08:30

🎨 delete redundant header.

dbdbb9d

Merge remote-tracking branch 'origin/add_operational_to_total_ratio' …

131de28

…into add_operational_to_total_ratio

github-actions bot reviewed Sep 16, 2024

View reviewed changes

Drewniok added 2 commits September 16, 2024 14:49

Merge branch 'main' into add_operational_to_total_ratio

5aeb7ed

📝 small bug fix.

6f89285

github-actions bot reviewed Sep 16, 2024

View reviewed changes

marcelwa requested changes Sep 17, 2024

View reviewed changes

Drewniok and others added 3 commits September 18, 2024 07:41

🎨 implement Marcel's comments.

1981be0

🎨 Incorporated pre-commit fixes

a0cb573

📝 Update pyfiction docstrings

5a4ca2e

Signed-off-by: GitHub Actions <actions@github.com>

github-actions bot reviewed Sep 18, 2024

View reviewed changes

Drewniok and others added 5 commits September 18, 2024 07:55

🎨 small fix.

2ddc0e6

🎨 Incorporated pre-commit fixes

dab3160

🎨 small fix.

b168377

Merge remote-tracking branch 'origin/add_operational_to_total_ratio' …

71f5784

…into add_operational_to_total_ratio

🎨 small fix.

77f4c02

github-actions bot reviewed Sep 18, 2024

View reviewed changes

🎨 update test-tag

ae4e6c7

Drewniok requested a review from marcelwa September 18, 2024 06:44

github-actions bot reviewed Sep 18, 2024

View reviewed changes

marcelwa reviewed Sep 18, 2024

View reviewed changes

docs/algorithms/sidb_simulation.rst Outdated Show resolved Hide resolved

docs/algorithms/sidb_simulation.rst Outdated Show resolved Hide resolved

📝 small fix.

88eae4f

github-actions bot reviewed Sep 18, 2024

View reviewed changes

Drewniok requested a review from marcelwa September 20, 2024 06:44

marcelwa approved these changes Sep 20, 2024

View reviewed changes

Drewniok merged commit 18bafd2 into cda-tum:main Sep 20, 2024
59 checks passed

✨ Added support for optional input parameter points in flood fill #518

✨ Added support for optional input parameter points in flood fill #518

Uh oh!

Conversation

Drewniok commented Aug 30, 2024

Description

Checklist:

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Sep 2, 2024 •

edited

Loading