Skip to content

🚨 Adapted code to solve gcc-14 issue #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

🚨 Adapted code to solve gcc-14 issue #501

wants to merge 7 commits into from

Conversation

Drewniok
Copy link
Collaborator

Description

This PR introduces small code changes to fix compilation errors when using gcc-14.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the compiler issue A platform-dependent problem label Aug 15, 2024
@Drewniok Drewniok self-assigned this Aug 15, 2024
@Drewniok Drewniok mentioned this pull request Aug 15, 2024
Merged
6 tasks
@Drewniok Drewniok closed this Aug 15, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (76e9458) to head (330b05a).
Report is 69 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   98.26%   98.25%   -0.01%     
==========================================
  Files         220      220              
  Lines       30100    30103       +3     
  Branches     1470     1470              
==========================================
+ Hits        29578    29579       +1     
- Misses        522      524       +2
Files with missing lines Coverage Δ
include/fiction/io/print_layout.hpp 95.13% <100.00%> (ø)
include/fiction/utils/layout_utils.hpp 98.99% <100.00%> (+0.01%) ⬆️
test/algorithms/iter/bdl_input_iterator.cpp 97.18% <100.00%> (ø)
...t/algorithms/physical_design/design_sidb_gates.cpp 100.00% <100.00%> (ø)
...simulation/sidb/displacement_robustness_domain.cpp 99.33% <100.00%> (ø)
test/io/print_layout.cpp 100.00% <100.00%> (ø)
test/utils/layout_utils.cpp 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e9458...330b05a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Drewniok Drewniok

Labels
compiler issue A platform-dependent problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Drewniok @marcelwa @actions-user