Skip to content

🐛 Enforce runtime evaluation of dynamic formatting strings to fix consteval contexts #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

🐛 Enforce runtime evaluation of dynamic formatting strings to fix consteval contexts #585

merged 2 commits into from
Nov 18, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Nov 17, 2024 •
edited
Loading

Description

This PR enforces the use of fmt::runtime in scenarios where dynamic formatting strings are used with the {fmt} library in order to fix compilation errors when these functions are used in consteval contexts.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the small fix Non-critical issue or inconsistency label Nov 17, 2024
@marcelwa marcelwa self-assigned this Nov 17, 2024
github-actions[bot]
github-actions bot reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov Codecov
Copy link

codecov bot commented Nov 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (735daab) to head (10b0924).
Report is 122 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #585   +/-   ##
=======================================
  Coverage   98.09%   98.10%           
=======================================
  Files         232      232           
  Lines       35300    35300           
  Branches     1700     1700           
=======================================
+ Hits        34628    34630    +2     
+ Misses        672      670    -2
Files with missing lines Coverage Δ
include/fiction/io/print_layout.hpp 95.08% <ø> (ø)
include/fiction/io/write_svg_layout.hpp 91.39% <ø> (ø)
include/fiction/layouts/coordinates.hpp 100.00% <100.00%> (ø)
include/fiction/technology/cell_ports.hpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 735daab...10b0924. Read the comment docs.

github-actions[bot]
github-actions bot reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@marcelwa marcelwa merged commit 300912a into main Nov 18, 2024
66 checks passed
@marcelwa marcelwa deleted the runtime-fmt-fix branch November 18, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@marcelwa marcelwa

Labels
small fix Non-critical issue or inconsistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcelwa