Skip to content

💚 Added fiction namespace to function to fix the Windows CI #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 1, 2024
Merged

💚 Added fiction namespace to function to fix the Windows CI #561

merged 5 commits into from
Nov 1, 2024

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Nov 1, 2024 •
edited
Loading

Description

This PR fixes the windows CI by adding the fiction namespace to the to_fiction_coord function.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok changed the title 💚 Addfiction namespace to fix windows issue. 💚 Added fiction namespace to fix windows CI. Nov 1, 2024
@Drewniok Drewniok self-assigned this Nov 1, 2024
@Drewniok Drewniok added the compiler issue A platform-dependent problem label Nov 1, 2024
@Drewniok Drewniok changed the title 💚 Added fiction namespace to fix windows CI. 💚 Added fiction namespace to function fix windows CI. Nov 1, 2024
@Drewniok Drewniok changed the title 💚 Added fiction namespace to function fix windows CI. 💚 Added fiction namespace to function to fix windows CI. Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok requested a review from marcelwa November 1, 2024 11:40
@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (076ab74) to head (a1a5045).
Report is 88 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   98.21%   98.21%   -0.01%     
==========================================
  Files         228      228              
  Lines       35727    35729       +2     
  Branches     1692     1691       -1     
==========================================
+ Hits        35091    35092       +1     
- Misses        636      637       +1
Files with missing lines Coverage Δ
...simulation/sidb/displacement_robustness_domain.hpp 97.67% <100.00%> (+0.02%) ⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 076ab74...a1a5045. Read the comment docs.

marcelwa
marcelwa approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@marcelwa marcelwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@marcelwa marcelwa changed the title 💚 Added fiction namespace to function to fix windows CI. 💚 Added fiction namespace to function to fix windows CI Nov 1, 2024
@marcelwa marcelwa changed the title 💚 Added fiction namespace to function to fix windows CI 💚 Added fiction namespace to function to fix the Windows CI Nov 1, 2024
@marcelwa marcelwa merged commit c9d9656 into cda-tum:main Nov 1, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

Assignees

@Drewniok Drewniok

Labels
compiler issue A platform-dependent problem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drewniok @marcelwa