Many thanks! I'm just a bit confused by the folder structure. If I were looking for the AND gate, I would expect the path to be sidb_gate_libraries/siqad/and.sqd. Could you explain your design decision?

clang-tidy review says "All clean, LGTM! 👍"

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (18f0c4c) to head (bd7fa45).
Report is 90 commits behind head on main.

@@            Coverage Diff             @@
##             main     #555      +/-   ##
==========================================
- Coverage   98.21%   98.21%   -0.01%     
==========================================
  Files         228      228              
  Lines       35730    35730              
  Branches     1692     1691       -1     
==========================================
- Hits        35094    35093       -1     
- Misses        636      637       +1     

Many thanks! I'm just a bit confused by the folder structure. If I were looking for the AND gate, I would expect the path to be sidb_gate_libraries/siqad/and.sqd. Could you explain your design decision?

Hmm, we could live without the subfolders. This structure is still from the time when we did not have the bdl_input_iterator. So up to 5 files were stored for each gate.
However, at the moment it is quite convenient for the experiment because the name of the gate is always given by the folder and the file itself can be named arbitrarily.

Many thanks! I'm just a bit confused by the folder structure. If I were looking for the AND gate, I would expect the path to be sidb_gate_libraries/siqad/and.sqd. Could you explain your design decision?

Hmm, we could live without the subfolders. This structure is still from the time when we did not have the bdl_input_iterator. So up to 5 files were stored for each gate. However, at the moment it is quite convenient for the experiment because the name of the gate is always given by the folder and the file itself can be named arbitrarily.

I understand where this is coming from. Regarding the convenience, you could just as easily argue the opposite: The name of the gate is given by the file name and you could put whatever files in the folder and they would automatically work with the experiments if they simply iterate over all SQD files in the sidb_gate_libraries/siqad/ directory.

Many thanks! I'm just a bit confused by the folder structure. If I were looking for the AND gate, I would expect the path to be sidb_gate_libraries/siqad/and.sqd. Could you explain your design decision?

Hmm, we could live without the subfolders. This structure is still from the time when we did not have the bdl_input_iterator. So up to 5 files were stored for each gate. However, at the moment it is quite convenient for the experiment because the name of the gate is always given by the folder and the file itself can be named arbitrarily.

I understand where this is coming from. Regarding the convenience, you could just as easily argue the opposite: The name of the gate is given by the file name and you could put whatever files in the folder and they would automatically work with the experiments if they simply iterate over all SQD files in the sidb_gate_libraries/siqad/ directory.

Yes, I know, it is true 😅. I will change it for the Bestagon and SiQAD gates, right?

Many thanks! I'm just a bit confused by the folder structure. If I were looking for the AND gate, I would expect the path to be sidb_gate_libraries/siqad/and.sqd. Could you explain your design decision?

Hmm, we could live without the subfolders. This structure is still from the time when we did not have the bdl_input_iterator. So up to 5 files were stored for each gate. However, at the moment it is quite convenient for the experiment because the name of the gate is always given by the folder and the file itself can be named arbitrarily.

I understand where this is coming from. Regarding the convenience, you could just as easily argue the opposite: The name of the gate is given by the file name and you could put whatever files in the folder and they would automatically work with the experiments if they simply iterate over all SQD files in the sidb_gate_libraries/siqad/ directory.

Yes, I know, it is true 😅. I will change it for the Bestagon and SiQAD gates, right?

Many thanks 🙏

clang-tidy review says "All clean, LGTM! 👍"

clang-tidy review says "All clean, LGTM! 👍"