Skip to content

🐛 Fixed several bugs resulting from the new cell_type::LOGIC in the SiDB technology #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 4, 2024
Merged

🐛 Fixed several bugs resulting from the new cell_type::LOGIC in the SiDB technology #553

merged 17 commits into from
Nov 4, 2024

Conversation

Drewniok
Copy link
Collaborator

Description

This PR fixes several bugs related to the new cell type LOGIC in the sidb technology.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the bug Something isn't working label Oct 30, 2024
@Drewniok Drewniok self-assigned this Oct 30, 2024
github-actions[bot]
github-actions bot reviewed Oct 30, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.21%. Comparing base (62fd917) to head (3967e2e).
Report is 134 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   98.22%   98.21%   -0.01%     
==========================================
  Files         228      228              
  Lines       35729    35746      +17     
  Branches     1691     1692       +1     
==========================================
+ Hits        35094    35109      +15     
- Misses        635      637       +2
Files with missing lines Coverage Δ
include/fiction/io/read_sqd_layout.hpp 90.68% <100.00%> (+0.11%) ⬆️
include/fiction/io/write_sqd_layout.hpp 100.00% <100.00%> (ø)
test/io/read_sqd_layout.cpp 100.00% <100.00%> (ø)
test/io/write_sqd_layout.cpp 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62fd917...3967e2e. Read the comment docs.

github-actions[bot]
github-actions bot reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Drewniok Drewniok requested a review from marcelwa October 31, 2024 12:56
marcelwa
marcelwa previously approved these changes Oct 31, 2024
View reviewed changes
@marcelwa marcelwa changed the title 🐛 Fixed several bugs due to new cell_type in sidb technology. 🐛 Fixed several bugs resulting from the new cell_type::LOGIC in the SiDB technology Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

clang-tidy review says "All clean, LGTM! 👍"

github-actions[bot]
github-actions bot reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@Drewniok Drewniok requested a review from marcelwa November 2, 2024 09:31
github-actions[bot]
github-actions bot reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 2, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024

clang-tidy review says "All clean, LGTM! 👍"

@Drewniok Drewniok merged commit 9d184b3 into cda-tum:main Nov 4, 2024
65 checks passed
@Drewniok Drewniok deleted the update_write_read_sqd branch November 4, 2024 14:33
@Drewniok Drewniok mentioned this pull request Nov 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@marcelwa marcelwa marcelwa approved these changes

Assignees

@Drewniok Drewniok

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Drewniok @marcelwa