Skip to content

👷 Update GCC versions on macOS CIs #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 16, 2024
Merged

👷 Update GCC versions on macOS CIs #499

merged 5 commits into from
Aug 16, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Aug 14, 2024 •
edited
Loading

Description

This PR bumps the GCC versions on macOS CIs due to incompatibility with the latest GitHub runner software package updates.

Additionally, it introduces a workaround for a compiler error in GCC 14 that occured on the convert_to_siqad_coordinates function. Many thanks to @Drewniok for this fix!

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the github_actions Pull requests that update GitHub Actions code label Aug 14, 2024
@marcelwa marcelwa self-assigned this Aug 14, 2024
@Drewniok Drewniok mentioned this pull request Aug 15, 2024
Merged
6 tasks
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (76e9458) to head (55c1913).
Report is 72 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #499   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         220      220           
  Lines       30100    30103    +3     
  Branches     1470     1471    +1     
=======================================
+ Hits        29578    29582    +4     
+ Misses        522      521    -1
Files with missing lines Coverage Δ
include/fiction/io/print_layout.hpp 95.13% <100.00%> (ø)
include/fiction/utils/layout_utils.hpp 98.99% <100.00%> (+0.01%) ⬆️
test/algorithms/iter/bdl_input_iterator.cpp 97.18% <100.00%> (ø)
...t/algorithms/physical_design/design_sidb_gates.cpp 100.00% <100.00%> (ø)
...simulation/sidb/displacement_robustness_domain.cpp 99.33% <100.00%> (ø)
test/io/print_layout.cpp 100.00% <100.00%> (ø)
test/utils/layout_utils.cpp 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76e9458...55c1913. Read the comment docs.

@marcelwa marcelwa merged commit 3e5e2d0 into main Aug 16, 2024
60 checks passed
@marcelwa marcelwa deleted the macos-gcc-version-update branch August 16, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@marcelwa marcelwa

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelwa @Drewniok @actions-user