Skip to content

✨ Planar Graph-Oriented Layout Design #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 12, 2024
Merged

✨ Planar Graph-Oriented Layout Design #497

merged 14 commits into from
Aug 12, 2024

Conversation

simon1hofmann
Copy link
Collaborator

Description

Added flag for the creation of planar layouts.
Currently depends on #496.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann requested a review from marcelwa August 12, 2024 12:40
@simon1hofmann simon1hofmann requested a review from hibenj August 12, 2024 12:40
@simon1hofmann simon1hofmann self-assigned this Aug 12, 2024
@simon1hofmann simon1hofmann added the enhancement New feature or request label Aug 12, 2024
@actions-user
📝 Update pyfiction docstrings
d7dcafd 
Signed-off-by: GitHub Actions <actions@github.com>
marcelwa
marcelwa reviewed Aug 12, 2024
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Aug 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (3ac16ac) to head (eda89c8).
Report is 71 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files         220      220           
  Lines       30092    30098    +6     
  Branches     1470     1470           
=======================================
+ Hits        29569    29575    +6     
  Misses        523      523
Files with missing lines Coverage Δ
...s/physical_design/graph_oriented_layout_design.hpp 100.00% <100.00%> (ø)
...s/physical_design/graph_oriented_layout_design.cpp 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ac16ac...eda89c8. Read the comment docs.

@marcelwa marcelwa merged commit ffa34ba into cda-tum:main Aug 12, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

@hibenj hibenj Awaiting requested review from hibenj

Assignees

@simon1hofmann simon1hofmann

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simon1hofmann @marcelwa @actions-user