Skip to content

🚨 Fixed compiler warnings #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 19, 2024
Merged

🚨 Fixed compiler warnings #480

merged 7 commits into from
Jul 19, 2024

Conversation

simon1hofmann
Copy link
Collaborator

@simon1hofmann simon1hofmann commented Jul 19, 2024 •
edited
Loading

Description

Fixed compiler warnings:
warning: declaration of 'x_offset' shadows a lambda capture [-Wshadow]
warning: declaration of 'y_offset' shadows a lambda capture [-Wshadow]
warning: conversion from ‘long unsigned int’ to ‘unsigned int:31’ may change value [-Wconversion]

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@simon1hofmann simon1hofmann self-assigned this Jul 19, 2024
@simon1hofmann simon1hofmann added the small fix Non-critical issue or inconsistency label Jul 19, 2024
@simon1hofmann simon1hofmann requested a review from marcelwa July 19, 2024 12:06
@codecov Codecov
Copy link

codecov bot commented Jul 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (7696fa6) to head (3daf9d7).
Report is 60 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #480      +/-   ##
==========================================
- Coverage   98.22%   98.22%   -0.01%     
==========================================
  Files         214      214              
  Lines       28957    28960       +3     
  Branches     1379     1379              
==========================================
+ Hits        28444    28446       +2     
- Misses        513      514       +1
Files with missing lines Coverage Δ
...ithms/physical_design/post_layout_optimization.hpp 100.00% <ø> (ø)
...on/algorithms/physical_design/wiring_reduction.hpp 98.69% <100.00%> (+<0.01%) ⬆️

... and 3 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7696fa6...3daf9d7. Read the comment docs.

@marcelwa marcelwa merged commit c1cfe49 into cda-tum:main Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwa marcelwa marcelwa approved these changes

Assignees

@simon1hofmann simon1hofmann

Labels
small fix Non-critical issue or inconsistency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simon1hofmann @marcelwa