Skip to content

Add webhook deployment to chart #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Add webhook deployment to chart #170

merged 1 commit into from
Sep 12, 2022

Conversation

ccremer
Copy link
Owner

@ccremer ccremer commented Sep 10, 2022 •
edited
Loading

Summary

  • Updates the chart to deploy a dedicated webhook server
  • Has some breaking changes in the parameter usage, please see readme

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    kind:bug, kind:enhancement, kind:documentation, kind:change, kind:breaking, kind:dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:clustercode
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

@ccremer ccremer added kind:breaking Breaking change that requires upgrading area:chart chart:clustercode labels Sep 10, 2022
@ccremer ccremer changed the title Update chart with webhook deployment Add webhook deployment to chart Sep 10, 2022
Base automatically changed from webhook to master September 12, 2022 15:52
@ccremer ccremer marked this pull request as ready for review September 12, 2022 16:03
@ccremer ccremer merged commit d8fd0ce into master Sep 12, 2022
@ccremer ccremer deleted the chart-webhook branch September 12, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:chart chart:clustercode kind:breaking Breaking change that requires upgrading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ccremer