Skip to content

Conversation

srohmen
Copy link
Contributor

@srohmen srohmen commented Mar 20, 2023

This fixes #1262

@srohmen srohmen force-pushed the fix-conformance-flags branch from d9a7e11 to 2e33ac6 Compare March 20, 2023 16:57
@jrosdahl jrosdahl added bug Does not work as intended/documented compiler: msvc Related to Microsoft Visual C++ labels Mar 28, 2023
@jrosdahl
Copy link
Member

jrosdahl commented Mar 28, 2023

Looking at the MSVC documentation, there are lots of other options that begin with /Z, so I don't think that the right fix is to make a special case for /Zc. Instead I think we should make a special case for /Zi, /ZI and /Z7 and leave other /Z options alone. This was the intention when implementing #1239, but I trusted the issue title too much without checking the docs.

@jrosdahl jrosdahl added this to the 4.8.1 milestone Mar 28, 2023
@srohmen srohmen force-pushed the fix-conformance-flags branch from 2e33ac6 to afdac66 Compare April 3, 2023 16:53
@tru
Copy link
Contributor

tru commented Apr 6, 2023

I tested the latest version of this patch on our code base and it worked just fine.

@jrosdahl
Copy link
Member

Thanks.

@srohmen srohmen deleted the fix-conformance-flags branch June 22, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Does not work as intended/documented compiler: msvc Related to Microsoft Visual C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSVC /Zc: parameters are no longer supported since version 4.8
3 participants