fix: recover from panic in handlers #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x/sync/errgroup does not currently propagate recovers, see golang/go#53757
98417f6 to
3af6154
Compare
cbrgm
approved these changes
Mar 6, 2025
|
Released in v2.0.1, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x/sync/errgroup does not currently propagate recovers, see golang/go#53757
Hey @cbrgm, this pull request will prevent the event handler from crashing on panic. It cannot be patch on around the handler because of how errgroup works.
So this PR simply adds a recover on top of each handler et set a panic recovered error