chore(lazygit): remove IFD #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents IFD without reintroducing the issue described in catppuccin#455
22864a6 to
0cbab18
Compare
alejandro-angulo
commented
Jul 5, 2025
| let | ||
| configFiles = [ | ||
| "${sources.lazygit}/${cfg.flavor}/${cfg.accent}.yml" | ||
| ] ++ lib.optional (config.programs.lazygit.settings != { }) configFile; |
There was a problem hiding this comment.
If I understand the issue in #455 correctly, the issue is that home manager doesn't write lazygit's config file if we have an empty attrset.
This will break if someone doesn't use home manager to manage their lazygit config file (and for some reason only manages the theme config with this flake ¯\_(ツ)_/¯ ) but I think it's fine to assume users will manage the config with home manager.
13 tasks
isabelroses
approved these changes
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents IFD without reintroducing the issue described in #455