Skip to content

Conversation

aivarasbaranauskas
Copy link
Contributor

Align EApiPredictionType enum in catboost/libs/model_interface/c_api.h with NCB::NModelEvaluation::EPredictionType in catboost/libs/model/enums.h.

Align EApiPredictionType enum in catboost/libs/model_interface/c_api.h with NCB::NModelEvaluation::EPredictionType in catboost/libs/model/enums.h
@aivarasbaranauskas
Copy link
Contributor Author

aivarasbaranauskas commented Apr 17, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@andrey-khropov
Copy link
Member

Thank you!

This is indeed a bug so that SetPredictionType(modelHandle, APT_CLASS) will try to compute MultiProbability instead. I created an issue #2643 for that.

@andrey-khropov
Copy link
Member

I've fixed the mismatch by adjusting NCB::NModelEvaluation::EPredictionType in eb65468 because that is preferable than changing public API in c_api.h.

You can change this PR to add MultiProbability or it can be discarded.

@aivarasbaranauskas
Copy link
Contributor Author

Have update the PR to reflect changes in eb65468.

@andrey-khropov andrey-khropov changed the title Align prediction type enum in C API Add 'APT_MULTI_PROBABILITY' to EApiPredictionType Apr 25, 2024
robot-piglet pushed a commit that referenced this pull request Apr 25, 2024
…aivarasbaranauskas from #2639

9bb0809471f862f88424d32a9beb7966e1bc32c8

Pull Request resolved: 2639
@andrey-khropov
Copy link
Member

Merged in c2c2ac4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants