Use mkstemp to replace deprecated mktemp #2660
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrey-khropov
requested changes
Jun 12, 2024
| _cached_download(train_urls, train_md5, train_path) | ||
|
|
||
| test_urls = ( | ||
| 'https://proxy.sandbox.yandex-team.ru/779120000', | ||
| 'https://archive.ics.uci.edu/ml/machine-learning-databases/adult/adult.test', ) | ||
| test_md5 = '35238206dfdf7f1fe215bbb874adecdc' | ||
| test_path = tempfile.mktemp() | ||
| fd_test, train_path = tempfile.mkstemp() |
andrey-khropov
approved these changes
Aug 19, 2024
robot-piglet
pushed a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request addresses a security concern related to the use of the deprecated tempfile.mktemp() function, which is known to be insecure due to its susceptibility to race conditions that can lead to temporary file vulnerabilities, as described in CWE-377.
Changes Made
Replaced tempfile.mktemp() with tempfile.mkstemp() in /catboost/python-package/catboost/datasets.py. tempfile.mkstemp() securely creates a temporary file by returning both a file descriptor and a path, which significantly minimizes the risk of file-based race conditions.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.