Skip to content

Add functions for getting indices of features of different types to C API #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add functions for getting indices of features of different types to C API #2568

wants to merge 3 commits into from

Conversation

nimusp
Copy link
Contributor

@nimusp nimusp commented Jan 11, 2024

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en.

I am adding methods for retrieving feature indices.
The Python API already has it, but the C API is missing it.

@nimusp
add GetFloatFeatureIndices, GetCatFeatureIndices, GetTextFeatureIndic…
2238f31 
…es and GetEmbeddingFeatureIndices methods to C API
andrey-khropov
andrey-khropov reviewed Jan 19, 2024
View reviewed changes
andrey-khropov
andrey-khropov requested changes Jan 19, 2024
View reviewed changes
@nimusp nimusp requested a review from andrey-khropov January 21, 2024 10:48
@andrey-khropov andrey-khropov changed the title extend C API Add functions for getting indices of features of different types to C API Jan 21, 2024
robot-piglet pushed a commit that referenced this pull request Jan 21, 2024
@andrey-khropov
Remove copy-paste related to error handling. #2568
998cc12
robot-piglet pushed a commit that referenced this pull request Jan 22, 2024
@andrey-khropov
Correct handling of empty indices vector case. #2568
9bf5846
robot-piglet pushed a commit that referenced this pull request Jan 22, 2024
@andrey-khropov
Correct error message in case of malloc failure. #2568
f1ad7f6
robot-piglet pushed a commit that referenced this pull request Jan 22, 2024
@andrey-khropov
Use std::copy. #2568
c6b01d7
robot-piglet pushed a commit that referenced this pull request Jan 22, 2024
@andrey-khropov
Switch to unsigned size_t for feature indices type. #2568
4f64b26
robot-piglet pushed a commit that referenced this pull request Jan 22, 2024
@andrey-khropov
Follow switch int -> size_t in tests. #2568
d36ccd8
@andrey-khropov andrey-khropov mentioned this pull request Feb 10, 2024
Open
robot-piglet pushed a commit that referenced this pull request Feb 22, 2024
@andrey-khropov
Add Get*FeaturesIndices to C++ wrapper. #2323, #2568
56a0b44 
f06ddcb379b925fbe1521afed2ba1e6f43a043b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-khropov andrey-khropov andrey-khropov approved these changes

Assignees
No one assigned
Labels
C/C++ applier
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimusp @andrey-khropov