TFocalMetric negative values fix #2386
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please do the following steps:
ya make
in catboost folder to make sure the code builds.ya make -t -A
command.1 - +
2 - cmake via
python setup.py bdist_wheel --no-widget
builds it successfully.3 - tests were not written by me, this is a fix for what's covered already - focal loss that I also wrote
4 - +
5 - I Did it already on the initial focal loss commit, but anyways I agree to it here.
The actual case was that metric in some cases becomes negative, which is not possible for focal loss itself by design.
The mistake is that I copied
loss
code part tometric
code part - which means it calculated as the metric the sum of the first and second derivatives of the loss, not the loss itself.Surely sum of derivatives could be negative, and while this does not affect the actual model(the loss is correct), it confused users by showing although diminishing, loss value going negative.