Skip to content

Change **chekpoint to **kwargs #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 27, 2021
Merged

Conversation

MrNightSky
Copy link
Contributor

Change extra arguments into pack_checkpoint function to save all parameters. Need for resume option.

Pull Request FAQ

Description

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

  • Have you updated tests for the new functionality?
  • Have you added your new classes/functions to the docs?
  • Have you updated the CHANGELOG?
  • Have you run colab minimal CI/CD with latest and minimal requirements?
  • Have you checked XLA integration with single and multiple processes?

Change extra arguments into pack_checkpoint function to save all parameters. Need for resume option.
@MrNightSky
Copy link
Contributor Author

Can add the same for ApexEngine after approval.

bagxi
bagxi previously requested changes Dec 22, 2021
@Scitator
Copy link
Member

@MrNightSky could you please also fix apex version?

@mergify mergify bot dismissed bagxi’s stale review December 27, 2021 04:25

Pull request has been modified.

@Scitator Scitator merged commit e5d163d into catalyst-team:master Dec 27, 2021
@MrNightSky
Copy link
Contributor Author

@Scitator sorry, that I didn't answer so long. Too much work before New Year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants