Arch update 21/11 - let's simplify it a bit ;) #1346

Scitator · 2021-11-05T07:56:03Z

Pull Request FAQ

documentation
contribution guide
minimal examples section
changelog for main framework updates
Catalyst slack (#__questions channel) for issue discussion

Description

Related Issue

Type of Change

Examples / docs / tutorials / contributors update
Bug fix (non-breaking change which fixes an issue)
Improvement (non-breaking change which improves an existing feature)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Checklist

Have you updated tests for the new functionality?
Have you added your new classes/functions to the docs?
Have you updated the CHANGELOG?
Have you run colab minimal CI/CD with latest and minimal requirements?
Have you checked XLA integration with single and multiple processes?

github-actions · 2021-11-05T09:07:19Z

catalyst/contrib/data/sampler.py

+from typing import Iterator, List, Optional, Union
+from collections import Counter
+import logging
+from operator import itemgetter


[pep8] _{reported by reviewdog 🐶}
F401 'operator.itemgetter' imported but unused

github-actions · 2021-11-05T09:07:19Z

catalyst/contrib/data/sampler.py

+import numpy as np
+
+import torch
+from torch.utils.data import DistributedSampler


[pep8] _{reported by reviewdog 🐶}
F401 'torch.utils.data.DistributedSampler' imported but unused

github-actions · 2021-11-05T09:07:19Z

catalyst/contrib/data/sampler.py

+from torch.utils.data import DistributedSampler
+from torch.utils.data.sampler import BatchSampler, Sampler
+
+from catalyst.data.dataset import DatasetFromSampler


[pep8] _{reported by reviewdog 🐶}
F401 'catalyst.data.dataset.DatasetFromSampler' imported but unused

pep8speaks · 2021-11-05T09:33:17Z

Hello @Scitator! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-11-07 08:23:12 UTC

github-actions · 2021-11-05T09:42:42Z

catalyst/callbacks/mixup.py

@@ -56,7 +56,7 @@ def forward(self, x):

        class SimpleDataset(torch.utils.data.Dataset):
            def __init__(self, train: bool = False):
-                self.mnist = MNIST(os.getcwd(), train=train, download=True, transform=ToTensor())
+                self.mnist = MNIST(os.getcwd(), train=train, download=True, transform=ImageToTensor())


[pep8] _{reported by reviewdog 🐶}
E501 line too long (102 > 99 characters)

github-actions · 2021-11-05T09:42:42Z

catalyst/callbacks/mixup.py

@@ -56,7 +56,7 @@ def forward(self, x):

        class SimpleDataset(torch.utils.data.Dataset):
            def __init__(self, train: bool = False):
-                self.mnist = MNIST(os.getcwd(), train=train, download=True, transform=ToTensor())
+                self.mnist = MNIST(os.getcwd(), train=train, download=True, transform=ImageToTensor())


[pep8] _{reported by reviewdog 🐶}
W505 doc line too long (102 > 99 characters)

github-actions · 2021-11-05T09:42:42Z

catalyst/contrib/data/_misc.py

+    Returns:
+        indices of the all elements equal x0
+    """
+    if isinstance(it, np.ndarray):


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'np'

github-actions · 2021-11-05T09:42:42Z

catalyst/contrib/data/_misc.py

+        indices of the all elements equal x0
+    """
+    if isinstance(it, np.ndarray):
+        inds = list(np.where(it == value)[0])


[pep8] _{reported by reviewdog 🐶}
F821 undefined name 'np'

github-actions · 2021-11-05T09:42:42Z

catalyst/contrib/data/sampler_inbatch.py

@@ -1,4 +1,4 @@
-from typing import List, Tuple, Union
+from typing import Any, Iterable, List, Tuple, Union


[pep8] _{reported by reviewdog 🐶}
F401 'typing.Any' imported but unused

github-actions · 2021-11-05T09:42:42Z

catalyst/contrib/data/sampler_inbatch.py

@@ -1,4 +1,4 @@
-from typing import List, Tuple, Union
+from typing import Any, Iterable, List, Tuple, Union


[pep8] _{reported by reviewdog 🐶}
F401 'typing.Iterable' imported but unused

github-actions · 2021-11-05T09:42:43Z

tests/catalyst/callbacks/test_metric.py

@@ -12,9 +12,8 @@

 from catalyst import data, dl
 from catalyst.callbacks.metric import BatchMetricCallback, LoaderMetricCallback
-from catalyst.contrib import datasets, models, nn
+from catalyst.contrib import data, datasets, models, nn


[pep8] _{reported by reviewdog 🐶}
F811 redefinition of unused 'data' from line 13

a few simplifications

dcfe3f6

Scitator requested review from bagxi and ditwoo as code owners November 5, 2021 07:56

Scitator added 2 commits November 5, 2021 10:48

docs simplifications

8dda154

fix

4522ac9

github-actions bot reviewed Nov 5, 2021

View reviewed changes

fix

9ebd235

fix

1c19e3b

github-actions bot reviewed Nov 5, 2021

View reviewed changes

Scitator added 13 commits November 5, 2021 11:56

fix

1f6934f

fix

c37526f

fix

f43046a

fix

0248f14

fix

f3a9f39

fix

13bc5f6

fix

a1cba01

fix

daf49a0

fix

c6cfecb

fix

7c2c626

fix

b2eb4c6

contrib simplification

88b3336

fix

c50b063

Scitator merged commit 809cd22 into master Nov 7, 2021

mergify bot deleted the arch-update-2111 branch November 7, 2021 18:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Arch update 21/11 - let's simplify it a bit ;) #1346

Arch update 21/11 - let's simplify it a bit ;) #1346

Uh oh!

Scitator commented Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

pep8speaks commented Nov 5, 2021 •

edited

Loading

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

github-actions bot Nov 5, 2021

Uh oh!

Uh oh!

		@@ -1,4 +1,4 @@
		from typing import List, Tuple, Union
		from typing import Any, Iterable, List, Tuple, Union

Uh oh!

Arch update 21/11 - let's simplify it a bit ;) #1346

Arch update 21/11 - let's simplify it a bit ;) #1346

Uh oh!

Conversation

Scitator commented Nov 5, 2021

Pull Request FAQ

Description

Related Issue

Type of Change

PR review

Checklist

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

pep8speaks commented Nov 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated at 2021-11-07 08:23:12 UTC

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

github-actions bot Nov 5, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pep8speaks commented Nov 5, 2021 •

edited

Loading