Skip to content

fix extra / #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 2, 2019
Merged

fix extra / #484

merged 7 commits into from
Nov 2, 2019

Conversation

KhrulkovV
Copy link
Contributor

@KhrulkovV KhrulkovV commented Oct 31, 2019 •
edited
Loading

Description

The argument logdir in CheckpointCallback is slightly incorrect which results in extra /. E.g.,
logs/resnet101_28_5e-05_0.001_480_True/checkpoints//train.0.pth 0.4945

Related Issue

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the Code of Conduct document.
  • I have read the Contributing guide.
  • I have checked the code-style using make check-style.
  • I have written the docstring in Google format for all the methods and classes that I used.
  • I have checked the docs using make check-docs.

@KhrulkovV KhrulkovV requested a review from TezRomacH October 31, 2019 10:45
@TezRomacH
Copy link
Contributor

Hi, could you please wrap the logdirs to pathlib.Path without manual removing the slash?

@Scitator Scitator added the WIP Pull request is under construction label Nov 1, 2019
@Scitator
Copy link
Member

Scitator commented Nov 1, 2019

@KhrulkovV @TezRomacH Please uncheck WIP label after the discussion and final implementation :)

@KhrulkovV
Copy link
Contributor Author

Hi, could you please wrap the logdirs to pathlib.Path without manual removing the slash?

Fixed!

TezRomacH
TezRomacH reviewed Nov 2, 2019
View reviewed changes
@TezRomacH TezRomacH merged commit 822d606 into master Nov 2, 2019
@TezRomacH TezRomacH deleted the fix/checkpoint-path branch November 2, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TezRomacH TezRomacH TezRomacH approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
WIP Pull request is under construction
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KhrulkovV @TezRomacH @Scitator