-
-
Notifications
You must be signed in to change notification settings - Fork 394
Added all_metrics to CheckpointCallback, issue #431 #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All metrics now will be collected in list, and written with best, n_best, last checkpoint metrics.
I know, i haven't made any changes to BaseCheckpointCallback here. But i wonder why do we have to do it this way, changing base class, if such logic is complex enough? |
@TezRomacH What do you think about this solution? |
I'm gonna check it tonight, thanks a lot for participating ❤️ |
@Arquestro could you add the same logic to |
No problem for me, but are you sure that's okay to duplicate such logic? I mean, that it maybe doesn't fit the base class but double the code. |
@Arquestro For now we can try the proposal with "double code" and then check out how we can improve it. Before that – it can be overoptimization. |
Done |
Description
All metrics now will be collected in list, and written with best, n_best, last checkpoint metrics.
Related Issue
#431
Type of Change
Checklist
make check-style
.make check-docs
.