Add dice jaccard callbacks #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…us/catalyst into add_dice_jaccard_callbacks
Scitator
reviewed
Oct 14, 2019
10 tasks
…us/catalyst into add_dice_jaccard_callbacks
|
PTAL @Scitator |
Scitator
reviewed
Oct 28, 2019
TezRomacH
suggested changes
Oct 28, 2019
Scitator
reviewed
Nov 3, 2019
catalyst/dl/callbacks/metrics/iou.py
Outdated
| @@ -41,4 +49,89 @@ def __init__( | |||
|
|
|||
| JaccardCallback = IouCallback | |||
|
|
|||
| __all__ = ["IouCallback", "JaccardCallback"] | |||
|
|
|||
| def calculate_jaccard(tp_fp_fn_dict: dict) -> np.array: | |||
There was a problem hiding this comment.
looks like we can remove the code duplication here also
catalyst/dl/callbacks/metrics/iou.py
Outdated
|
|
||
| tp_fp_fn_dict = calculate_tp_fp_fn(self.confusion_matrix) | ||
|
|
||
| batch_metrics: Dict = calculate_jaccard(tp_fp_fn_dict) |
There was a problem hiding this comment.
here you can use just calculate_jaccard(**tp_fp_fn_dict)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.