Skip to content

Pytorch 1.3 support #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2019
Merged

Pytorch 1.3 support #447

merged 2 commits into from
Oct 13, 2019

Conversation

TezRomacH
Copy link
Contributor

@TezRomacH TezRomacH commented Oct 13, 2019 •
edited
Loading

Description

Pytorch implemented the OneCycleLR in version 1.3
To make Catalyst work as planned I renamed our realization to OneCycleLRWithWarmup

Related Issue

N/A

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CODE_OF_CONDUCT document.
  • I have read the CONTRIBUTING document.
  • I have checked the code-style using make check-style.
  • I have written the docstring in Google format for all the methods and classes that I used.
  • I have checked the docs using make check-docs.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@Scitator Scitator merged commit ac2a6ea into master Oct 13, 2019
@TezRomacH TezRomacH deleted the pytorch-1.3-support branch October 13, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TezRomacH @Scitator