Skip to content

Loggers logic out of RunnerState #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 30, 2019
Merged

Loggers logic out of RunnerState #443

merged 14 commits into from
Oct 30, 2019

Conversation

TezRomacH
Copy link
Contributor

@TezRomacH TezRomacH commented Oct 12, 2019 •
edited
Loading

Description

Trying to move loggers out of RunnerState to Runner

Related Issue

I'm planning on adding this #414

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CODE_OF_CONDUCT document.
  • I have read the CONTRIBUTING document.
  • I have checked the code-style using make check-style.
  • I have written the docstring in Google format for all the methods and classes that I used.
  • I have checked the docs using make check-docs.

@TezRomacH TezRomacH added enhancement New feature or request WIP Pull request is under construction labels Oct 12, 2019
@TezRomacH TezRomacH changed the title [WIP] Loggers out of RunnerState Loggers logic out of RunnerState Oct 21, 2019
@TezRomacH TezRomacH removed the WIP Pull request is under construction label Oct 21, 2019
@TezRomacH TezRomacH requested a review from Scitator October 21, 2019 11:32
@Scitator Scitator merged commit b27d8de into master Oct 30, 2019
@TezRomacH TezRomacH deleted the refactor/loggers_out_of_state branch October 30, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scitator Scitator Awaiting requested review from Scitator Scitator is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TezRomacH @Scitator