Skip to content

Migration from tensorboardX to PyTorch native Tensorboard, issue #435 #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2019
Merged

Migration from tensorboardX to PyTorch native Tensorboard, issue #435 #439

merged 6 commits into from
Oct 15, 2019

Conversation

Arquestro
Copy link
Contributor

@Arquestro Arquestro commented Oct 11, 2019 •
edited
Loading

Migration from tensorboardX to PyTorch native Tensorboard.

Description

Changes:

  1. Requirements updated, minimum PyTorch version is 1.2.0 now, tensorboardX -> tensorboard.
  2. All tensorboardX package references have been changed to torch.utils.tensorboard.
  3. Important change in catalyst/utils/tensorboard.py: Event imported from tensorboard.compat.proto.event_b2, not from tensorboardX.proto.eventb2.

Related Issue

#435

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CODE_OF_CONDUCT document.
  • I have read the CONTRIBUTING document.
  • I have checked the code-style using make check-style.
  • I have written the docstring in Google format for all the method and classes that I used.
  • I have checked the docs using make check-docs.

@Arquestro
Changed requirements.txt file, added tensorboard, pytorch>=1.2.0. Cha…
e9efff0 
…nged tensorboardX package to torch.utils.tensorboard
@Arquestro
Copy link
Contributor Author

I've ran tensorboard test from utils, seemed good to me, with no errors.
But, still afraid that Event import can break it, maybe it's only me. :)

@Arquestro
Update README.md
cafef0a 
Pytorch compatibilitiy minimum version changed
TezRomacH
TezRomacH reviewed Oct 11, 2019
View reviewed changes
@Scitator
Copy link
Member

Hi,

thinking about this PR, is it possible to save backward compatibility with some kind of try-except mechanism? or check pytorch version?
Reason: we still have a lot of users with pytorch 1.0 :)

@Arquestro
Copy link
Contributor Author

It is possible, but i'm afraid that there will be a lot of bugs in a solution and confuse with package configurations. @TezRomacH do you have any other possible proposals on this?

@Scitator
Copy link
Member

@Arquestro what type of package configurations confuse?
looks like you need just to check PyTorch version, if it is below 1.2.0 – used tensorboardX.
We still can have tensorboardX in the requirements for some time.

@Arquestro
Copy link
Contributor Author

Well then none, if we can keep tensorboardX. But there will be one excess package in requirements - tensorboard or tensoboardX.

I'll try to implement and test the solution proposed anyway. :)

TezRomacH
TezRomacH suggested changes Oct 15, 2019
View reviewed changes
@Scitator
Copy link
Member

Really cool PR, thanks!

@Scitator Scitator merged commit fec22af into catalyst-team:master Oct 15, 2019
@TezRomacH TezRomacH mentioned this pull request Nov 7, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@TezRomacH TezRomacH TezRomacH approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arquestro @Scitator @TezRomacH