-
-
Notifications
You must be signed in to change notification settings - Fork 394
Fix Epoch Number for Console Logging #411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Epoch Number for Console Logging #411
Conversation
Hi, thanks for PR! Nevertheless, working with checkpoint indices, we also need to logs correctness. In your example, best model saved as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. I missed that. Since all the logs are epoch zero based, I propose that we keep it as is but update the total number of epochs in the console progress bar. To keep it consistent. Let me know if you would prefer a full refactoring of the epoch number so that it starts at 1 everywhere & I will do that instead. |
@Scitator let me know what you think of this: Added Multi-Stage Training Example Stage 1: [...] Stage 2: Loading from Stage 2 Checkpoint: Looking at the plots Stage 1: Stage 2: Loading from Stage 2 Checkpoint: |
Was not expecting travis to fail for such a small change. Let me look into it first. Sorry. |
Hah, @ostamand looks like you also need to rewrite tests a bit :) |
@Scitator Cool thanks for the tests commit! I was about to take a look at it. Let me know if there is any other change you want me to do? |
Fix epoch number in console logging.
Before:
After: