refactor extractProcess to use io.ReadAll instead of bufio.Reader #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
internal/cli/cli.gofile to improve the efficiency and readability of theextractProcessfunction. The most important changes include replacing the line-by-line reading with a single read operation and simplifying the error handling.Code efficiency and readability improvements:
internal/cli/cli.go: Replaced the line-by-line reading of the input stream with a single read operation usingio.ReadAll, which simplifies the code and potentially improves performance.internal/cli/cli.go: Removed the loop and associated error handling for reading lines, as the entire input is now read at once.