Skip to content

Handle edge cases for input without final newline in CLI processing #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

catatsuy
Copy link
Owner

This pull request enhances the handling of input data processing and improves test coverage in the internal/cli/cli.go file. The most important changes include processing remaining data when the end of the file is reached and adding new test cases to cover these scenarios.

Enhancements to Input Data Processing:

  • internal/cli/cli.go: Added logic to process the remaining data when the end of the file is reached in the replaceProcess and filterProcess functions. [1] [2]

Improvements to Test Coverage:

  • internal/cli/cli_test.go: Added new test cases to ensure that the replaceProcess and filterProcess functions handle input without a trailing newline correctly. [1] [2]

@catatsuy catatsuy merged commit c80fc00 into main Aug 12, 2024
5 checks passed
@catatsuy catatsuy deleted the fix-add-remaining-data-processing-for-cli branch August 12, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant