Use merge base commit for diffs and shallow clone in auto-review #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic ReviewOne issue in error handling and robustness stands out related to the GitHub API and shell commands:
Suggestion: - name: Install dependencies
run: sudo apt-get update && sudo apt-get install -y jq
Suggestion:
Suggestion: echo "HEAD_SHA=${HEAD_SHA}" >> $GITHUB_ENVThen later: MERGE_BASE=${{ env.MERGE_BASE_SHA }}
HEAD=${{ env.HEAD_SHA }}
git diff ${MERGE_BASE} ${HEAD} ...This ensures the correct commits are used throughout. In summary, improvements: - name: Install dependencies
run: sudo apt-get update && sudo apt-get install -y jq
- name: Fetch necessary commits
run: |
BASE_SHA="${{ github.event.pull_request.base.sha }}"
HEAD_SHA="${{ github.event.pull_request.head.sha }}"
echo "Base SHA: ${BASE_SHA}"
echo "Head SHA: ${HEAD_SHA}"
MERGE_BASE_SHA=$(curl -s \
-H "Authorization: token ${{ secrets.GITHUB_TOKEN }}" \
-H "Accept: application/vnd.github+json" \
"https://api.github.com/repos/${{ github.repository }}/compare/${BASE_SHA}...${HEAD_SHA}" | jq -r '.merge_base_commit.sha')
if [ "$MERGE_BASE_SHA" = "null" ] || [ -z "$MERGE_BASE_SHA" ]; then
echo "Error: Could not retrieve merge base commit SHA."
exit 1
fi
echo "Merge base commit SHA: ${MERGE_BASE_SHA}"
echo "MERGE_BASE_SHA=${MERGE_BASE_SHA}" >> $GITHUB_ENV
echo "HEAD_SHA=${HEAD_SHA}" >> $GITHUB_ENV
git fetch --depth=1 origin ${MERGE_BASE_SHA} || echo "Warning: Failed to fetch merge base commit"
- name: Check for diffs and set SKIP_REVIEW
run: |
MERGE_BASE=${{ env.MERGE_BASE_SHA }}
HEAD=${{ env.HEAD_SHA }}
echo "Using merge base: ${MERGE_BASE} and head: ${HEAD}"
DIFF_OUTPUT=$(git diff ${MERGE_BASE} ${HEAD} -- ':!go.sum')
DIFF_LINES=$(echo "$DIFF_OUTPUT" | wc -l)
if [ -z "$DIFF_OUTPUT" ]; then
echo "No changes detected, skipping review."
echo "SKIP_REVIEW=true" >> $GITHUB_ENV
exit 0
elif [ "$DIFF_LINES" -gt 500 ]; then
echo "Diff too large (${DIFF_LINES} lines), skipping review."
echo "SKIP_REVIEW=true" >> $GITHUB_ENV
exit 0
fiThis will avoid silent failures, undefined variables, and missing dependencies leading to clearer, more reliable workflows. |
c18a073 to
1898a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the GitHub Actions workflow in
.github/workflows/auto-review.ymlto optimize the handling of shallow clones and improve the accuracy of diffs by using the merge base commit. It also introduces a new language model and localization for the review process.Workflow optimization and diff accuracy:
fetch-depthparameter in theactions/checkoutstep to1for a shallow clone, reducing the amount of data fetched. Added a step to fetch the merge base commit for accurate diff generation.MERGE_BASE_SHA) instead of the base branch reference, ensuring more precise comparisons.Review process improvements:
bentoreview command to use thegpt-4.1-minimodel and generate reviews in Japanese, enhancing the review process with a specific language model and localization.