feat: add Gemini backend support #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- internal/gemini/testdata/gemini_success.json: Language not supported
Comments suppressed due to low confidence (1)
internal/cli/cli.go:360
- Update the inline comment to match the default Gemini model ('gemini-2.0-flash-lite') defined in the constants for consistency.
Model: useModel, // e.g., "gemini-2.0-flash"
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- internal/gemini/testdata/gemini_success.json: Language not supported
Comments suppressed due to low confidence (2)
internal/gemini/client.go:15
- The variable name GeminiAPIURL is potentially misleading since the URL contains 'openai'. Consider renaming it or adding a clarifying comment to indicate it is the endpoint for Gemini.
var GeminiAPIURL = "https://generativelanguage.googleapis.com/v1beta/openai/chat/completions"
internal/cli/cli.go:172
- [nitpick] Overwriting the default OpenAI model with the Gemini default for the Gemini backend might be unexpected; consider adding a comment or log to inform users that the default model is being switched when using the gemini backend.
if useModel == DefaultOpenAIModel { useModel = DefaultGeminiModel }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the
internal/cli/cli.gofile to add support for a new backend, Gemini, alongside the existing OpenAI backend. It also includes the implementation of the Gemini client and its associated tests. Below are the most important changes:CLI Enhancements:
backendflag to specify the backend to use, eitheropenaiorgemini. (internal/cli/cli.go) [1] [2]Runmethod to select the appropriate translator based on thebackendflag and set the corresponding API key environment variable. (internal/cli/cli.go)Gemini Client Implementation:
GeminiTranslatorstruct and implemented therequestmethod to interact with the Gemini API. (internal/cli/cli.go)internal/geminipackage, which includes theClient,Payload,Message, andResponsetypes, as well as methods for creating a new client and sending chat requests. (internal/gemini/client.go)Testing:
internal/gemini/client_test.go)internal/gemini/testdata/gemini_success.json)Code Cleanup and Documentation:
internal/cli/cli.gofile. (internal/cli/cli.go) [1] [2] [3]internal/cli/cli.go) [1] [2]These changes collectively enhance the CLI tool by adding support for the Gemini backend, improving code readability, and ensuring robust testing for the new functionality.