Skip to content

add public properties to DateInterval stubs #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2025
Merged

add public properties to DateInterval stubs #273

merged 1 commit into from
Aug 10, 2025

Conversation

Bleksak
Copy link
Contributor

@Bleksak Bleksak commented Aug 7, 2025 •
edited
Loading

📌 What Does This PR Do?

Adds readonly DateInterval properties to stubs as described here:
https://www.php.net/manual/en/class.dateinterval.php#dateinterval.props.y

🔍 Context & Motivation

Eliminate false positives when using the analyzer.

🛠️ Summary of Changes

  • Bug Fix: Eliminate some false positives regarding to DateInterval by adding its public properties to stubs

📂 Affected Areas

  • Linter
  • Formatter
  • CLI
  • Composer Plugin
  • Dependencies
  • Documentation
  • Other (please specify): Analyzer

@azjezz azjezz self-assigned this Aug 10, 2025
@azjezz azjezz added Priority: High After critical issues are fixed, handle these before any further issues. Status: Accepted The issue’s subject and resolution approach is confirmed. Type: Bug An issue causing unintended or problematic behavior. Type: Enhancement Request for additions or changes that improve existing functionality. Subject: Analyzer An issue or PR related to the static analyzer/type checker. labels Aug 10, 2025
@azjezz azjezz merged commit 03f9f3b into carthage-software:main Aug 10, 2025
4 checks passed
@azjezz azjezz added Status: Completed Nothing further to do; awaiting closure out of politeness. and removed Status: Accepted The issue’s subject and resolution approach is confirmed. labels Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@azjezz azjezz

Labels
Priority: High After critical issues are fixed, handle these before any further issues. Status: Completed Nothing further to do; awaiting closure out of politeness. Subject: Analyzer An issue or PR related to the static analyzer/type checker. Type: Bug An issue causing unintended or problematic behavior. Type: Enhancement Request for additions or changes that improve existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bleksak @azjezz