Skip to content

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Dec 12, 2023

No description provided.

Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kabeor please take a look at this one too

@Rot127 Rot127 marked this pull request as draft December 16, 2023 12:50
@Rot127
Copy link
Collaborator Author

Rot127 commented Dec 16, 2023

@wargio is currently working on MIPS and thanks to his questions I discover a lot of weaknesses and outdated info in the current docs.
So I mark this as draft for now. Because there are probably some more changes coming.

@Rot127 Rot127 mentioned this pull request Dec 19, 2023
@Rot127 Rot127 marked this pull request as ready for review January 6, 2024 11:17
@Rot127
Copy link
Collaborator Author

Rot127 commented Jan 6, 2024

Marked this as ready for review, since I think it is more valuable to have those changes merged soon (to answer questions like this: #2234 (comment)). If anything else comes up, it can be part of a different PR.

Copy link
Contributor

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM then.

@XVilka
Copy link
Contributor

XVilka commented Jan 7, 2024

@kabeor this one is ready to be merged now.

@kabeor
Copy link
Member

kabeor commented Jan 7, 2024

Cool, merged.

@kabeor kabeor merged commit 0d0edad into capstone-engine:next Jan 7, 2024
@Rot127 Rot127 deleted the as-docs branch March 31, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants