Skip to content

SystemZ SYSZ_OP_ACREG can be removed #2423

@david942j

Description

@david942j

It's not really a bug but more like a tech-debt that after PR #1306, all registers in operands are considered as in the same family SYSZ_OP_REG even for the Access Registers. This fact makes the existence of SYSZ_OP_ACREG confusing. One may check the operands against SYSZ_OP_ACREG but it would never match.

From cstool on v4, d7e459d

cstool/cstool -d sysz 'b24f0078'
 0  b2 4f 00 78        ear      %r7, %a8
        ID: 383 (ear)
        op_count: 2
                operands[0].type: REG = 7
                operands[1].type: ACREG = 8 // <- reports type in SYSZ_OP_ACREG

on v5, 7905571:

cstool/cstool -d sysz 'b24f0078'
 0  b2 4f 00 78        ear      %r7, %a8
        ID: 383 (ear)
        op_count: 2
                operands[0].type: REG = 7
                operands[1].type: REG = a8 // <- type becomes SYSZ_OP_REG

To address this issue the macro SYSZ_OP_ACREG should be remove to prevent confusions.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions