Set the CAPROVER_GIT_COMMIT_SHA env var automatically when building #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are able to and the environment variable isn't already in use, we set the CAPROVER_GIT_COMMIT_SHA env var to the git has that is being deployed. This allows it to be used when building the image and can be copied into the image to use a runtime as well. Fixes caprover#922
|
Thanks, this is great! |
|
Hi Matt, I have made no other changes to the app config (no other environment variables). I'm not sure what sort of information would be helpful in tracking down the issue, but am happy to provide whatever may be needed. Thanks for getting the PR into Caprover though, this will be really helpful for a project I'm working on! |
|
Moved to #1198 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the CAPROVER_GIT_COMMIT_SHA env var automatically when building
When we are able to and the environment variable isn't already in use, we set the CAPROVER_GIT_COMMIT_SHA env var to the git has that is being deployed. This allows it to be used when building the image and can be copied into the image to use a runtime as well.
Tests performed
Closes #922