-
Notifications
You must be signed in to change notification settings - Fork 927
Closed
Description
What is the problem?
When editing a registry, if I put the wrong username, password or domain, then Save and Update, I get what seems to be a successful notice saying "Registry updated". I think the authentication check is being incorrectly skipped when editing a registry (but correctly executed when adding a registry).
Steps to reproduce the problem:
- Click on Cluster on the left sidebar
- Under Docker Registries, click Add Remote Registry
- Enter any dummy invalid values in Username, Password, and Domain
- Click on Add Remote Registry in the popup dialog box
- I get a red notice saying
1112 : Athentication failed. Either username, password, or domain is incorrect.
(This is good and expected) - Under Docker Registries, click on Add Remote Registry
- Enter valid values in Username, Password, and Domain
- Click on Add Remote Registry in the popup dialog box
- I get a green notice saying:
Docker registry successfully added!
(This is good and expected) - Now, under Actions, click the Edit icon for the registry you just added
- Enter any dummy invalid values in Username, Password, and Domain
- Click on Save and Update in the popup dialog box
- I get a green notice saying:
Registry updated.
(This is the bug. I expect to see the same authentication failure as in step 5 above)
Answers to the following questions where applicable:
- CapRover version?
CapRover 1.9.0
- Your OS and version?
Digital Ocean droplet: caprover-ubuntu-s-1vcpu-1gb-tor1-01
Ubuntu 18.04.5 LTS (GNU/Linux 4.15.0-132-generic x86_64)
System information as of Sat Feb 20 00:25:38 UTC 2021
System load: 0.16
Usage of /: 50.5% of 24.06GB
Memory usage: 62%
Swap usage: 0%
Processes: 124
- RAM?
1 GB
Metadata
Metadata
Assignees
Labels
No labels