-
Notifications
You must be signed in to change notification settings - Fork 927
Description
Is your feature request related to a problem? Please describe.
I would like contribute more and started setting up some oneclick definitions than i realised there is an issue with some Images from different Vendors for this Example im using https://github.com/jhuckaby/Cronicle which runs perfectly fine in caprover but is not deployable via OneClickApps because it needs a setted hostname for the container which is not great but not really changeable without making a custom image which has it problems.
We had this before as an issue here #250
The other case is this request caprover/one-click-apps#37 for Docker Mailserver which also runs perfectly fine with caprover but is mostly useless to implement as an oneclick cause it needs it setup.sh utitlity to be of any use so for example to be able to generate users etc. via the caprover interface there would be the need to attasch an pre deploy script.
Describe the solution you'd like
let us set a pre-deploy script in the OneClick definition.
This probably can have bad effects or lead to misuse which can make problems but i dont see another way to handle all of this together.
Describe alternatives you've considered
let the Hostname be confiquirable or assigned automaticly to the default domain for the container (which probably can make problems in multi instance deployments im not sure) which solves atleast the cronicle problem which at the moment is not really solveable without manually updating the container the pre deploy script would than need to be manually set by the user which is safer but less comfortable.
Additional context
Im probably able to implement all of this myself but its not worth much if it doesnt get merged or there are issues im not aware of so i would like to have a discussion before i start to invest time into implementation.
Thanks.