This repository was archived by the owner on Oct 10, 2024. It is now read-only.
Mlkit android #171
Merged
Mlkit android #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update BarcodeScanner.java reset scanResult after calling resumeScan * Update Plugin.swift reset scan result after calling resumeScan
Steps to reproduce : open the app in portrait/landscape mode => rotate => open the camera Issue the CameraView was being loaded when the app starts not with each scan. Somehow the cameraView doesn't recognize that the app has rotated
* feat(capacitor): update to capacitor v4 * fix(ios): small bugfixes * fix(ios): added self. to savedCall in scan() (capacitor-community#142) Co-authored-by: Kristof Hauser <hauser.kristof@gmail.com>
) Added more detailed troubleshooting, with a fix for the following capacitor-community#151
On iOS the `UIApplication.shared.statusBarOrientation` is deprecated and on newer versions obsolete. It has been replaced by code suggested here: https://askcodes.net/coding/-statusbarorientation--was-deprecated-in-ios-13-0-when-attempting-to-get-app-orientation capacitor-community#129
|
@1andonlyziz thank you very much for your work! I have not tested anything yet, but I will do this ASAP :) I will keep you updated here if that is okay for you :) |
|
@thegnuu thanks, lets get this ready for the community :) |
|
@1andonlyziz I just updated the ml-kit branch, had to make a few fixes but now it should work out of the box :) There are a few small things that needs to be done and some rewrite of the permission stuff should be done as well, but the branch now works on ios and android which is a major step forward! Thanks a lot for your great work!!! |
|
@thegnuu Thank you for giving me the opportunity to collaborate on this project ^_^ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.