add --show=name,email
#108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this PR, I took the approach of being minimally invasive and simply extending the patterns of the existing behavior. I'd much prefer to do a refactor of the logic to extract functions and classes to model the approach instead of using logic branches (if/else blocks) and flags, but I wouldn't want to invest that time unless I had some maintenance stake in the project. |
|
Thanks! Please ping me again here if I don't review in the next few days... |
|
@casperdcl Thanks for the offer of review. Let me know if you have any questions. |
|
@casperdcl Friendly bump. Let me know if this is something that's potentially to be accepted. Thanks! |
415e26c to
954e642
Compare
|
/tag v2.2.0 6c3311c |
|
Excellent! Love the improvements. Thanks for reviewing, merging, and releasing! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #96
Summary
Instead of gathering just the names during the main loop, the routine now gathers both the names and emails, and then depending on which flags were elected, perhaps only the names or only the emails will be rendered. Perhaps this behavior could be made the default, but for backward compatibility, it's an opt-in behavior for now.