#756 Complete multiple recipes in bash completion script #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain what this does and how it works? I don't understand the bash completion scripts at all 😅 |
|
This MR changes the generated completion script to additionally complete other recipes, e.g. # currently usage
just pwd test # test recipe is not in the completion list
# after change you can complete other recipies
just pwd test some-other-recipeThe generated completion script diff is the following: $ diff <(just --completions bash) <(cat ~/.local/share/bash-completion/just)
--- /dev/fd/63 2025-07-02 14:42:08.281502293 +0300
+++ /dev/fd/62 2025-07-02 14:42:08.281502293 +0300
@@ -34,7 +34,7 @@
if [[ ${cur} == -* ]] ; then
COMPREPLY=( $(compgen -W "${opts}" -- "${cur}") )
return 0
- elif [[ ${cword} -eq 1 ]]; then
+ else
local recipes=$(just --summary 2> /dev/null)
if echo "${cur}" | \grep -qF '/'; thenIt removes the limitation where completion stops working after first argument is provided. |
|
Why was |
|
That I do not know. |
|
T_T Well, in any case it seems to work, so merging. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.