Skip to content

feat: module recipe dependency support #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 3, 2025
Merged

feat: module recipe dependency support #2672

merged 8 commits into from
Jul 3, 2025
+265 −59

Conversation

corvusrabus
Copy link
Contributor

Support for recipe dependencies in a submodule

mod foo

baz: foo::bar

Contributes to #2252

Still needs a bit of work.

@corvusrabus corvusrabus marked this pull request as ready for review April 15, 2025 17:07
@corvusrabus
Copy link
Contributor Author

Sorry. Took me a while to come back to this. I think it's ready for review now @casey

@corvusrabus
Copy link
Contributor Author

Hey @casey. Any chance you have time to have a look :) ?

@casey casey enabled auto-merge (squash) July 3, 2025 22:42
@casey casey merged commit 0c0895f into casey:master Jul 3, 2025
6 checks passed
@casey
Copy link
Owner

casey commented Jul 3, 2025

Nice work! I refactored resolve_recipe to delegate to another function resolve_dependency which makes it a little cleaner and gets rid of some nesting, but otherwise looks great!

@casey casey mentioned this pull request Jul 12, 2025
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jul 14, 2025
Merged
@corvusrabus corvusrabus mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corvusrabus @casey