Skip to content

Named Partials render string result in stringOnly state #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2019
Merged

Named Partials render string result in stringOnly state #715

merged 3 commits into from
Aug 14, 2019

Conversation

cherifGsoul
Copy link
Member

Fixes #710

The changes:

The logic changes are in this line

can-stache/src/mustache_core.js

Line 293 in b530682

return res == null ? "" : ""+res;

  • Check if the returning result of branchRenderer is a DocumentFragment instance, in this case return the textContent of this result, ""+res doesn't cast DocumentFragment instance to string.

matthewp
matthewp requested changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change how it checks for document fragments. Otherwise looks good.

src/mustache_core.js Outdated
if (res == null) {
return "";
}
if (res instanceof DocumentFragment) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of checking instanceof, check res.nodeType === 11 which is a document fragment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@cherifGsoul cherifGsoul requested a review from matthewp August 14, 2019 18:26
matthewp
matthewp approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cherifGsoul cherifGsoul merged commit c7811b8 into master Aug 14, 2019
@cherifGsoul cherifGsoul deleted the i710-fix-named-partial-string-only-state branch August 14, 2019 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@phillipskevin phillipskevin Awaiting requested review from phillipskevin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Named Partials render with documentFragment in stringOnly state instead of expected string result
2 participants
@cherifGsoul @matthewp