Fix memory leak in portal helper #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the memory leak in the portal helper. The problem was that we were never unregistering the call to `domMutate.onNodeRemoval` so there was always a pointer to the MutationObserver that is observing the document. This adds a page in `benchmark/portal-mem.html` that can be used to find memory leaks. Fixes #684
bmomberger-bitovi
approved these changes
May 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the memory leak in the portal helper. The problem was that we
were never unregistering the call to
domMutate.onNodeRemovalso therewas always a pointer to the MutationObserver that is observing the
document.
This adds a page in
benchmark/portal-mem.htmlthat can be used to findmemory leaks.
Fixes #684