Warn when closing magic tag is missed #678
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmomberger-bitovi
requested changes
Apr 12, 2019
can-stache.js
Outdated
| // warn if closing magic tag is missed #675 | ||
| var last = state.sectionElementStack[state.sectionElementStack.length - 1]; | ||
| if (process.env.NODE_ENV !== 'production') { | ||
| if(section instanceof HTMLSectionBuilder) { |
There was a problem hiding this comment.
I don't think you need this line here. The block you copied this from (probabaly makeRendererAndUpdateSection) was in a function that was passed section as a parameter. In this function you're just referencing the top level section, which is always an HTMLSectionBuilder.
There was a problem hiding this comment.
Yeah, I added this check in the 2nd commit the first one was good.
Update testee to the latest version 🚀
* Handle nested call functions Allows use of returning functions from functions * Include stache test for nested call expression
This fixes the memory leak in the portal helper. The problem was that we were never unregistering the call to `domMutate.onNodeRemoval` so there was always a pointer to the MutationObserver that is observing the document. This adds a page in `benchmark/portal-mem.html` that can be used to find memory leaks. Fixes #684
Fix memory leak in portal helper
Use can-dom-data instead of can-dom-data-state
add documentation for data helper
can-stache.js
Outdated
| done: function(lineNo){ | ||
| //!steal-remove-start | ||
| // warn if closing magic tag is missed #675 | ||
| var last = state.sectionElementStack[state.sectionElementStack.length - 1]; |
|
I close this for #692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds warning when a closing magic tag is missed for example the following triggers a warning:
{{# let foo="bar"}} {{foo}}The changes:
The warning is added to done function
Fixes #675