Children don't bubble parent with functions #146
Conversation
bubble.js
Outdated
| @@ -144,7 +144,9 @@ var bubble = { | |||
| // For an event binding on an object, returns the events that should be bubbled. | |||
| // For example, `"change" -> ["change"]`. | |||
| events: function(map, boundEventName) { | |||
| return map.constructor._bubbleRule(boundEventName, map); | |||
| if (map && typeof map === 'object') { | |||
There was a problem hiding this comment.
When should bubbling happen? I think there is probably a better way to do this check. Either using canReflect.isFunctionLike or canReflect.isMapLike.
There was a problem hiding this comment.
Maybe this should check !canReflect.isFunctionLike(map) and the one in childrenOf should use canReflect.isMapLike(child)?
There was a problem hiding this comment.
@phillipskevin I made the requested updates.
canReflect.isMapLike(child) returns true with a function, so I just used !canReflect.isFunctionLike for both .
There was a problem hiding this comment.
So does the .childrenOf need && child.bind? What is this check for?
There was a problem hiding this comment.
I think it is the old way to check if the object is a can-map!
There was a problem hiding this comment.
Ok, this is what I meant to use isMapLike for
This is needed to fix canjs/can-list#97
The issue
An error is thrown when function events is bubbled to parent, the check is made by
.bindcan-map/bubble.js
Line 193 in 2f72c0f
for that reason, functions are always bubbled.
The changes
childrenOfinbubble.jsto bubble events to parent only onObjects/Mapbubble.js