Skip to content

Using the Symbol instead of the __inSetup property #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2019
Merged

Using the Symbol instead of the __inSetup property #422

merged 1 commit into from
Jan 10, 2019

Conversation

phillipskevin
Copy link
Contributor

Closes #421.
Depends on #421 (maybe not?)

@phillipskevin
Copy link
Contributor Author

I'm going to debug this a little more and test it out in canjs with and without the can-construct change before it's ready to merge.

@phillipskevin phillipskevin changed the title WIP: using the Symbol instead of the __inSetup property Using the Symbol instead of the __inSetup property Jan 10, 2019
@phillipskevin phillipskevin merged commit 180b442 into master Jan 10, 2019
@phillipskevin phillipskevin deleted the set-in-setup branch January 10, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinbmeyer justinbmeyer Awaiting requested review from justinbmeyer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phillipskevin