onPatches now checks for patch.type #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/list.js
Outdated
| @@ -152,7 +153,7 @@ ListDOMPatcher.prototype = { | |||
| this.move, | |||
| [patch.toIndex, patch.fromIndex] | |||
| ); | |||
| } else { | |||
| } else if (patch.type === "splice") { | |||
There was a problem hiding this comment.
is there a tab character between } and else
There was a problem hiding this comment.
there is not, that is not showing for me locally either.
e
There was a problem hiding this comment.
how can you tell when your tab width is 2?
There was a problem hiding this comment.
You were right! Thanks for the heads up. The changes have been pushed up.
bmomberger-bitovi
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
patch.type's"move"and"splice""add", "delete", "slice", and "values"are ignored