Skip to content

Queue all DOM updates in the dom queue #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 27, 2019

Conversation

bmomberger-bitovi
Copy link
Contributor

@bmomberger-bitovi bmomberger-bitovi commented Dec 6, 2019

  • For live.list, queue all removes and adds in the ListDOMPatcher together, and perform removes and adds when the dom queue is flushed.
  • For live.html, move updates from the notify queue to the dom queue; do adds right after removes when queue is flushing, rather than enqueuing again.
  • Add guards to the range helpers so they do not attempt to iterate removals on ranges that have already been torn down (i.e. when the start and end nodes no longer have parents nor siblings)
  • do patch sort on each patch passed into live.list rather than attempting to sort all patches (prevents "Could not group patches" error when 3 or more patches are dispatched)

Closes #150

@bmomberger-bitovi bmomberger-bitovi merged commit fbdcaca into master Dec 27, 2019
@bmomberger-bitovi bmomberger-bitovi deleted the dom-queue-all-updates branch December 27, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Unable to place item
1 participant