Migrate to org GitHub to Jira application #3931
Conversation
There was a problem hiding this comment.
Thank you Didier! This looks reasonable to me. I have only a few questions below and small suggestions inline.
- Out of curiosity, what is the motivation for the change?
- I don't suppose there is a way we could test this before merging?
- Is this all there is to it, or is anything else needed on Jira's court? How about "GitHub App installation"?
- I suppose after this we can remove
secrets.JIRA_WEBHOOK_URL, right? I didn't follow the current setup very closely TBH... is there anything else that we should be cleaning up, do you know?
| - jira | ||
| status_mapping: | ||
| opened: Untriaged | ||
| closed: Done |
There was a problem hiding this comment.
I guess not_planned: rejected would make sense too?
There was a problem hiding this comment.
see my global comment.
| - jira | ||
| status_mapping: | ||
| opened: Untriaged | ||
| closed: Done |
There was a problem hiding this comment.
Perhaps the label mapping from the example in the readme would make sense too?
label_mapping:
enhancement: Story
There was a problem hiding this comment.
see my global comment.
| @@ -0,0 +1,7 @@ | |||
| settings: | |||
There was a problem hiding this comment.
Could we perhaps have a top comment with some reference to docs or, failing that, the GH? Just so that future readers know what this is about.
There was a problem hiding this comment.
That’s a good suggestion, Let me add a top comment with the repo URL.
I have been reached out by Maksim now that the ubuntu organization is covered by the Canonical GitHub apps. It makes sense to only have one tool for it. Also, using a GitHub app is easier in term of maintenance (no more webhook to be installed, url to set in the repo…)
No, unfortunately, there is not. However, I have migrated 27 other projects to it, and I have tested it on gowsl too (ubuntu/GoWSL#130). The only difference between the PRs are the targetted project and components. I am highly confident this works too (and it’s valid yaml)! We can always refine afterwards.
The app is watching all ubuntu and canonical repo and is installed globally. No individual action is required on individual repos.
Indeed, this secrets can be removed once merged. I have done that or requested in all other repos. On the settings/mapping. I think those are good ideas. I think we can pilot on project doing this, and then, refresh all other ones we own (as desktop) to have the same set of settings. Would you candidate for this and reports how those works/evolve. Do you want to start with the initial set of mapping or add both right now? |
We have a new GitHub to Jira global organization application. The previous gh workflow action is now deprecated. UDENG-5960
4c53571 to
be5a20c
Compare
We have a new GitHub to Jira global organization application. The previous gh workflow action is now deprecated.
UDENG-5960