Fix transfer only partially transferring #3902
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3902 +/- ##
==========================================
- Coverage 89.11% 89.11% -0.01%
==========================================
Files 255 255
Lines 14600 14602 +2
==========================================
+ Hits 13011 13012 +1
- Misses 1589 1590 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hey @Sploder12, good work. A couple of matters for discussion inline.
There was a problem hiding this comment.
Alright, this looks good to me.
I tried transfers with different files, with random data, and they all worked. Unfortunately that's not worth much, because the same is true on the edge channel (i.e. I could not reproduce the original issue). Two other devs have verified the fix though, and the new code makes sense, so approving.
| @@ -77,10 +77,19 @@ struct SFTPClient : public testing::Test | |||
| return {std::make_unique<mp::SSHSession>("b", 43, "ubuntu", key_provider)}; | |||
| } | |||
|
|
|||
| // this is a macro since REPLACE only applies to the current scope and cannot be moved out. | |||
There was a problem hiding this comment.
Oh you need the capture so extracting the lambda wouldn't work. You'd need std::bind or another lambda again. Alright.
Fixes the issue of
multipass transferonly transferring some chunks of the file. This usessftp_limitsinstead of the constant65536uto determine the correct buffer size for SFTP reads and writes.Fixes #3892
MULTI-1768