[flutter] add local_notifier plugin & show local notification on update available #3724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
=======================================
Coverage 88.92% 88.92%
=======================================
Files 254 254
Lines 14299 14299
=======================================
Hits 12716 12716
Misses 1583 1583 ☔ View full report in Codecov by Sentry. |
andrei-toterman
suggested changes
Oct 11, 2024
f7aaca2 to
b8c8344
Compare
andrei-toterman
suggested changes
Oct 12, 2024
andrei-toterman
suggested changes
Oct 12, 2024
b8c8344 to
621dd88
Compare
andrei-toterman
suggested changes
Oct 14, 2024
| body: 'Version ${updateInfo.version} is available. Click to upgrade now.', | ||
| ); | ||
|
|
||
| notification.onClick = launchInstallUrl; |
There was a problem hiding this comment.
Oof, I thought that the notification will automatically close when you click it, but it doesn't, so it must be closed manually.
Suggested change
| notification.onClick = launchInstallUrl; | |
| notification.onClick = () async { | |
| await launchInstallUrl(); | |
| await notification.close(); | |
| }; |
621dd88 to
88645ec
Compare
andrei-toterman
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.